Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: T7036: upgrade validation improvements #4298

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

dmbaturin
Copy link
Member

Change summary

  • Provide a clear message that the upgrade is aborted due to a failed compatibility check.
  • Handle missing flavor and architecture data in the target image gracefully (that's expected to happen when someone tries to downgrade to a legacy image).
  • Handle missing data in the current image (unlikely but who knows when people may fiddle with the system?).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Prerequisite PR: #4297

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jan 9, 2025

👍
No issues in PR Title / Commit Title

@dmbaturin dmbaturin marked this pull request as ready for review January 28, 2025 18:21
@dmbaturin dmbaturin marked this pull request as draft January 28, 2025 18:33
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@dmbaturin dmbaturin force-pushed the T7036-upgrade-validation-improvements branch from d996537 to fb74bd9 Compare January 30, 2025 13:40
@dmbaturin dmbaturin marked this pull request as ready for review January 30, 2025 13:41
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@c-po c-po merged commit 6912eb2 into vyos:current Feb 2, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants