-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the firewall pages #1088
Conversation
Signed-off-by: Nephiaust <[email protected]>
Signed-off-by: Nephiaust <[email protected]>
Signed-off-by: Nephiaust <[email protected]>
Updated labels for the pages Added new pictures. Signed-off-by: Nephiaust <[email protected]>
@rebortg if you are happy with the style, I will continue updating the documentation. I will also fix the linting issues as well as part of the documentation updates. |
@@ -1,10 +1,10 @@ | |||
:lastproofread: 2021-06-29 | |||
|
|||
.. _firewall-legacy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you change the reference name, you must check the usage. For example it is use here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excluding those issues, happy with the overall style and layout? If so I will start working on fixing it all up properly (including the references).
|
||
.. _firewall: | ||
.. _firewall-configuration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here the same behavior with the reference name like in the legacy version
At first sight, content looks! It's good and necessary to improve vyos documentation. Thanks in advance for this work! |
i'm happy with all contribution. :-) |
Started updating the firewall pages, to explain how they work.
Updated the general, legacy and zone pages.
Need to do more work on the explainations, but wanted a review of the current work to see if its acceptable.