Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pycryptodome on arm #3485

Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix: pycryptodome on arm #3485

merged 1 commit into from
Jun 30, 2023

Conversation

charles-cooper
Copy link
Member

What I did

mac users were reporting bugs like:

OSError: Cannot load native module 'Crypto.Hash._keccak': Not found '_keccak.cpython-311-darwin.so', Cannot load '_keccak.abi3.so': Failed to load dynlib/dll '/<some directory>/Crypto/Util/../Hash/_keccak.abi3.so'. Most likely this dynlib/dll was not found when the application was frozen., Not found '_keccak.so'

How I did it

rebuild pycryptodome during packaging

How to verify it

build verified by @hedgar2017

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper requested a review from fubuloubu June 14, 2023 21:25
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Merging #3485 (4997410) into master (a71d604) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3485      +/-   ##
==========================================
+ Coverage   89.35%   89.44%   +0.08%     
==========================================
  Files          84       84              
  Lines       10776    10874      +98     
  Branches     2456     2517      +61     
==========================================
+ Hits         9629     9726      +97     
- Misses        751      754       +3     
+ Partials      396      394       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper merged commit 2704ff0 into master Jun 30, 2023
@charles-cooper charles-cooper deleted the chore/fix-pycryptodome branch June 30, 2023 00:02
@charles-cooper charles-cooper restored the chore/fix-pycryptodome branch September 19, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants