Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in and not in comparisons for dynamic arrays of enums #3526

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Jul 20, 2023

What I did

Fix #3522

How I did it

Skip the special branch handling enum memberships if the RHS may possibly be an array.

How to verify it

See tests.

Commit message

fix: `in` and `not in` comparisons for dynamic arrays of enums

Description for the changelog

Allow in and not in comparisons for dynamic arrays of enums

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #3526 (c39b0e9) into master (5482bbc) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head c39b0e9 differs from pull request most recent head 9033a30. Consider uploading reports for the commit 9033a30 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #3526      +/-   ##
==========================================
+ Coverage   89.08%   89.16%   +0.07%     
==========================================
  Files          86       84       -2     
  Lines       11455    10953     -502     
  Branches     2605     2503     -102     
==========================================
- Hits        10205     9766     -439     
+ Misses        830      775      -55     
+ Partials      420      412       -8     
Files Coverage Δ
vyper/semantics/analysis/utils.py 91.84% <100.00%> (-0.13%) ⬇️

... and 33 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: in and not in cannot be used with dynamic array of enums
2 participants