feat: relax restrictions on internal function signatures #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InterfaceT.from_ast already checks unique method ids, so the `validate_unique_method_ids` call in the `ModuleAnalyzer` constructor is redundant. TODO: add an explicit test for collision with a generated getter chainsec june 2023 review 5.22
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3573 +/- ##
==========================================
- Coverage 89.13% 89.06% -0.07%
==========================================
Files 85 85
Lines 11365 11367 +2
Branches 2585 2583 -2
==========================================
- Hits 10130 10124 -6
- Misses 813 821 +8
Partials 422 422
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fubuloubu
approved these changes
Aug 28, 2023
trocher
reviewed
Sep 1, 2023
charles-cooper
changed the title
charles-cooper
changed the title
relax the restriction on unique "method ids" for internal methods. the check used to be there to avoid collisions between external method ids and internal "method ids" because the calling convention for internal functions used to involve the method id as part of the signature, but that is no longer the case. so we can safely allow collision between internal "method ids" and external method ids. cf. issue vyperlang#1687 which was resolved in in 9e8c661. chainsec june 2023 review 5.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InterfaceT.from_ast already checks unique method ids, so the
validate_unique_method_idscall in theModuleAnalyzerconstructor is redundant. the check used to be there to avoid collisions between external method ids and internal "method ids" because the calling convention for internal functions used to involve the method id as part of the signature, but that is no longer the case. so we can safely allow collision between internal "method ids" and external method ids.chainsec june 2023 review 5.22
cf. #1687, resolved in #1800
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture