refactor: fix IRnode.from_list #3614
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3614 +/- ##
=======================================
Coverage 84.78% 84.79%
=======================================
Files 92 92
Lines 13129 13134 +5
Branches 2934 2936 +2
=======================================
+ Hits 11132 11137 +5
Misses 1534 1534
Partials 463 463 ☔ View full report in Codecov by Sentry. |
IRnode.from_list() currently has a footgun where it modifies metadata on the input. this commit copies the input to be slightly safer
charles-cooper
force-pushed
the
fix/irnode-factory
branch
from
4f9daa8 to
09712ba
Compare
|
one issue with this PR is it seems to make performance worse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRnode.from_list() currently has a footgun where it modifies metadata on the input. this commit copies the input to be slightly safer
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture