chore: improve error message for invalid address literal

[tserg]

What I did

Fix #3611

How I did it

Add BadChecksumAddress exception and catch it.

How to verify it

See tests.

Commit message

chore: improve error message for address literal

Description for the changelog

Improve error mesage for address literal that is not checksummed

Cute Animal Picture

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 68.77%. Comparing base (b4429cf) to head (ec1c45d).

Files	Patch %	Lines
vyper/semantics/analysis/utils.py	11.11%	8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #3621       +/-   ##
===========================================
- Coverage   85.19%   68.77%   -16.43%     
===========================================
  Files          92       92               
  Lines       13916    13923        +7     
  Branches     3118     3119        +1     
===========================================
- Hits        11856     9575     -2281     
- Misses       1565     3629     +2064     
- Partials      495      719      +224     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[charles-cooper]

interesting .. did

vyper/tests/ast/nodes/test_hex.py

Line 9 in 7b9d159

foo: constant(address) = 0x6b175474e89094c44da98b954eedeac495271d0F

not need to be changed?

also, is

vyper/vyper/semantics/types/primitives.py

Line 339 in 7b9d159

"Address checksum mismatch. If you are sure this is the right "

now dead code?

[tserg]

interesting .. did

vyper/tests/ast/nodes/test_hex.py

Line 9 in 7b9d159

foo: constant(address) = 0x6b175474e89094c44da98b954eedeac495271d0F

not need to be changed?
also, is

vyper/vyper/semantics/types/primitives.py

Line 339 in 7b9d159

"Address checksum mismatch. If you are sure this is the right "

now dead code?

It's actually not dead code, because validate_expected_type relies on this to throw an exception via types_from_Constant.

On second thought, I think a better way is to add an early return for Constant nodes to immediately call expected_type.validate_literal(node) in validate_expected_type. [EDIT: this still would not be sufficient on its own, because the invalid checksum address could be in a literal array]

Also, the AST test still passes because I had BadChecksumAddress inherit from InvalidLiteral. Should it inherit from VyperException instead?

[charles-cooper]

discussed offline -- it's a bit weird as there are actually two (three?) different places which construct similar error messages

[charles-cooper]

another issue is the literal check will fail even if the user doesn't want an address, e.x.:

vyper.exceptions.BadChecksumAddress: Address checksum mismatch. If you are sure this is the right address, the correct checksummed form is: 0x5124fcC2B3F99F571AD67D075643C743F38f1C34

  contract "tmp/repro2.vy:4", function "foo", line 4:15 
       3 def foo():
  ---> 4     x: uint8 = 0x5124fcc2b3f99f571ad67d075643c743f38f1C34
  ----------------------^
       5