chore: add metadata to vyper-json #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tserg
commented
Sep 26, 2023
| @@ -104,7 +104,6 @@ def build_ir_runtime_dict_output(compiler_data: CompilerData) -> dict: | |||
|
|
|||
|
|
|||
| def build_metadata_output(compiler_data: CompilerData) -> dict: | |||
| warnings.warn("metadata output format is unstable!") | |||
There was a problem hiding this comment.
Can this warning be removed?
charles-cooper
approved these changes
Sep 26, 2023
|
@tserg can we add a test for this in the vyper json tests? |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #3622 +/- ##
==========================================
- Coverage 89.09% 89.03% -0.07%
==========================================
Files 85 86 +1
Lines 11392 11460 +68
Branches 2591 2606 +15
==========================================
+ Hits 10150 10203 +53
- Misses 820 833 +13
- Partials 422 424 +2
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix #3619
How I did it
Add
metadataoutput tovyper-json.How to verify it
Commit message
chore: add metadata to vyper-json
Description for the changelog
Add metadata output for vyper-json.
Cute Animal Picture