Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support '_' separator in dec/oct/float numbers #3665

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

z80dev
Copy link
Contributor

@z80dev z80dev commented Nov 8, 2023

Allows 100_000 in place of 100000

What I did

modified grammar defining decimal, octal, and float numbers to match what vyper actually accepts and compiles

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@z80dev z80dev force-pushed the lark-allow-underscore-numerical-sep branch from ca32598 to 5739993 Compare November 9, 2023 00:57
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the new grammar breaks some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants