Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate vyper-serve #3666

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Nov 9, 2023

What I did

Deprecate vyper-serve.

How I did it

Delete files.

How to verify it

Commit message

feat: deprecate `vyper-serve`

Description for the changelog

Deprecate vyper-serve.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Merging #3666 (e4f157a) into master (4dd47e3) will increase coverage by 0.62%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #3666      +/-   ##
==========================================
+ Coverage   89.61%   90.24%   +0.62%     
==========================================
  Files          80       79       -1     
  Lines       11343    11264      -79     
  Branches     2553     2546       -7     
==========================================
  Hits        10165    10165              
+ Misses        791      712      -79     
  Partials      387      387              
Files Coverage Δ
vyper/__main__.py 0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@charles-cooper
Copy link
Member

Thank you! Maybe we should add some tests for this? Or maybe get rid of vyper serve altogether (as part of the compiler project). It could be standalone.

@fubuloubu
Copy link
Member

Or maybe get rid of vyper serve altogether (as part of the compiler project). It could be standalone.

We've been working on a standalone compiler service with remix (that supports any versions of vyper through VVM): https://github.com/ApeWorX/hosted-compiler

@tserg
Copy link
Collaborator Author

tserg commented Nov 10, 2023

Shall we get rid of vyper-serve entirely then?

@fubuloubu
Copy link
Member

Shall we get rid of vyper-serve entirely then?

I think that makes sense. Lessens maintenance overhead on vyper

@tserg tserg changed the title fix: update vyper-serve feat: deprecate vyper-serve Nov 11, 2023
@charles-cooper charles-cooper merged commit 98f502b into vyperlang:master Nov 20, 2023
83 of 84 checks passed
@tserg tserg deleted the chore/vyper_serve branch November 21, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants