chore: move venom tests to tests/unit/compiler
#3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harkal
approved these changes
Dec 7, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3684 +/- ##
==========================================
- Coverage 83.81% 83.60% -0.22%
==========================================
Files 91 91
Lines 12775 12775
Branches 2860 2860
==========================================
- Hits 10708 10680 -28
- Misses 1643 1668 +25
- Partials 424 427 +3 ☔ View full report in Codecov by Sentry. |
the previous code depended on eth-tester mining a block within 1 second. this fixes it to be invariant wrt eth-tester speed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
tests/compilerdirectory was moved totests/unit/in 4dd47e3 but this seems to have been missed in a merge during work on venom (cbac5ab)What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture