fix: allow using interface defs from imported modules

[charles-cooper]

What I did

fix #2900

How I did it

How to verify it

see new test

Commit message

- add interface defs to ModuleT's exposed `get_type_members()`
- slight refactor of ModuleT to have a special helper instead of
dispatching to `self.interface`

Description for the changelog

Cute Animal Picture

[pcaversaccio]

The unit test could be enriched with another test using a relative import from the parent directory (i.e. from ..dir.ifaces.IFoo import IFoo) just to ensure that the interface keyword doesn't break path resolution in some weird way.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6dc432) 84.11% compared to head (5a9139b) 83.86%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3725      +/-   ##
==========================================
- Coverage   84.11%   83.86%   -0.25%     
==========================================
  Files          92       92              
  Lines       13123    13119       -4     
  Branches     2926     2925       -1     
==========================================
- Hits        11038    11002      -36     
- Misses       1663     1693      +30     
- Partials      422      424       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[charles-cooper]

The unit test could be enriched with another test using a relative import from the parent directory (i.e. from ..dir.ifaces.IFoo import IFoo) just to ensure that the interface keyword doesn't break path resolution in some weird way.

in vyper you can't use from to import types inside of files. like in python, you can do from my_module import some_type. but in vyper you can't import individual names from a module -- the usage here would be from ..dir import ifaces; ... ; ifaces.IFoo.

[pcaversaccio]

The unit test could be enriched with another test using a relative import from the parent directory (i.e. from ..dir.ifaces.IFoo import IFoo) just to ensure that the interface keyword doesn't break path resolution in some weird way.

in vyper you can't use from to import types inside of files. like in python, you can do from my_module import some_type. but in vyper you can't import individual names from a module -- the usage here would be from ..dir import ifaces; ... ; ifaces.IFoo.

FWIW, I still use that syntax in snekmate: https://github.com/pcaversaccio/snekmate/blob/main/src%2Ftokens%2FERC20.vy#L75

[charles-cooper]

FWIW, I still use that syntax in snekmate: https://github.com/pcaversaccio/snekmate/blob/main/src%2Ftokens%2FERC20.vy#L75

yea as discussed offline -- that syntax was probably a bug, and it does not work anymore on master (probably as of #3663 ) anyways.

[pcaversaccio]

FWIW, I still use that syntax in snekmate: https://github.com/pcaversaccio/snekmate/blob/main/src%2Ftokens%2FERC20.vy#L75

yea as discussed offline -- that syntax was probably a bug, and it does not work anymore on master (probably as of #3663 ) anyways.

Yup, amended in snekmate via pcaversaccio/snekmate#194.