Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[venom]: binopt #4281

Open
wants to merge 70 commits into
base: master
Choose a base branch
from
Open

Conversation

HodanPlodky
Copy link
Collaborator

What I did

Started reimplementing the binary operation optimization and some additional from original pipeline to venom pipeline

How I did it

The optimization are done in the AlgebraicOptimizationPass since the types of optimizations nicely slots into the purpose of the pass. Most of the logic is directly taken from the original pipeline

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@HodanPlodky HodanPlodky changed the title Feat/binopt feat[venom]: binopt Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 46.98276% with 123 lines in your changes missing coverage. Please review.

Project coverage is 88.30%. Comparing base (fcddb70) to head (223d35b).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
vyper/venom/passes/sccp/sccp.py 43.72% 84 Missing and 37 partials ⚠️
vyper/venom/passes/algebraic_optimization.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4281      +/-   ##
==========================================
- Coverage   91.35%   88.30%   -3.06%     
==========================================
  Files         112      112              
  Lines       15923    16138     +215     
  Branches     2691     2756      +65     
==========================================
- Hits        14546    14250     -296     
- Misses        942     1342     +400     
- Partials      435      546     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HodanPlodky HodanPlodky marked this pull request as ready for review October 30, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants