-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[venom]: add calloca
instruction
#4376
base: master
Are you sure you want to change the base?
feat[venom]: add calloca
instruction
#4376
Conversation
this instruction is meant to help match call-site allocations with pallocas (inside the callee).
a5caad1
to
c647456
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4376 +/- ##
==========================================
+ Coverage 92.06% 92.07% +0.01%
==========================================
Files 120 120
Lines 17330 17358 +28
Branches 2932 2937 +5
==========================================
+ Hits 15955 15983 +28
Misses 957 957
Partials 418 418 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only checked the minimalist legacy update
What I did
promote the callee buffer (allocated at call site) to an alloca-like instruction.
there are a couple minor regressions in here:
one is fixed in #4419
the other is filed in #4420.
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture