feat[venom]: add venom parser #4381
Conversation
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
🚀 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vyper/venom/parser.py
Outdated
| ) | ||
| from vyper.venom.function import IRFunction | ||
| from lark import Lark, Transformer | ||
| from functools import reduce |
Check notice
Code scanning / CodeQL
Unused import Note
|
@charles-cooper btw how I would I toggle optimizations on-off for faster venom compilation? |
vyper/cli/vyper_venom.py
Outdated
| if args.evm_version is not None: | ||
| set_global_settings(Settings(evm_version=args.evm_version)) | ||
|
|
||
| if args.input_file is None: |
There was a problem hiding this comment.
i'd rather have the unix convention of - indicating stdin, or maybe --stdin arg
| bb.insert_instruction(instruction) | ||
|
|
||
| # Manually insert because we need to override function entry | ||
| fn._basic_block_dict[block_name] = bb |
There was a problem hiding this comment.
does fn.append_basic_block(bb) not work here?
There was a problem hiding this comment.
No because when you initialize a basic block it automatically also creates the starting block so I want to be able to overwrite that
vyper/venom/parser.py
Outdated
|
|
||
| ctx.data_segment = data_section | ||
|
|
||
| ctx.chain_basic_blocks() |
There was a problem hiding this comment.
does chain_basic_blocks() need to be called? or should we assume the user input is well-formed?
There was a problem hiding this comment.
I don't quite understand it but I think it's somewhat required to build the basic CFG and determine whether the CFGs terminate or not?
There was a problem hiding this comment.
Oh wait, I think I found the issue "revert" is not considered a basic block terminator (not in vyper/venom/basicblock.py:BB_TERMINATORS) so that was giving me errors.
There was a problem hiding this comment.
Yes, revert is not a terminator. You can have multiple reverts in a block and that is ok.
| for fn_name, blocks in funcs: | ||
| fn = ctx.create_function(fn_name) | ||
| for block_name, instructions in blocks: | ||
| bb = IRBasicBlock(IRLabel(block_name), fn) |
There was a problem hiding this comment.
i think we might want to update ctx.last_label as well
There was a problem hiding this comment.
last_label doesn't seem to be used anywhere?
| fallback: | ||
| revert 0, 0 | ||
| fn global => { |
There was a problem hiding this comment.
it's a little bit weird that functions are curly brace delimited but basic blocks are indent delimited
There was a problem hiding this comment.
(not a huge deal, but it's something to think about -- either making basic blocks curly brace delimited or functions whitespace delimited)
There was a problem hiding this comment.
tbh I like the mix, makes it clear which is which, if you really want can change
There was a problem hiding this comment.
I think I side with @charles-cooper on this. Seems weird to only have braces only for that part. Also is doesn't sit well with me as venom is more of a simple "assembly" like language, so no need for deep nesting.
What I did
I added a "frontend" for venom, allowing you to compile independent venom files.
How I did it
I defined a new grammar (a bit simpler than what the readme initially suggested) & parser using the
larkparser generator library.How to verify it
Run the
venomCLI against the example in the readme by putting it in aexample.venomfile and runningvenom example.venomCommit message
feat[venom]: add frontend
Description for the changelog
Added independent CLI for compiling venom
Cute Animal Picture