Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for RLPList #816

Merged
merged 5 commits into from
May 21, 2018
Merged

Conversation

mkeen
Copy link
Contributor

@mkeen mkeen commented May 10, 2018

- What I did

Fixes: #606
Added documentation for RLPList.

- How I did it

Through research on another issue I learned a little bit about how to use RLPList, and noticed this issue, so I documented what I learned.

- How to verify it

Run make docs and open ./docs/_build/html/built-in-functions.html

- Description for the changelog

Added documentation for RLPList

- Cute Animal Picture

Duckling

@mkeen mkeen closed this May 12, 2018
@mkeen mkeen reopened this May 12, 2018
@jacqueswww
Copy link
Contributor

jacqueswww commented May 15, 2018

@mkeen could you add notes in the documentation that RLP decoder needs to be deployed for this.
We will eventually create a fixed address for the decoder on mainnet, however the decoder in the code currently used only for the test suite (see https://github.com/ethereum/vyper/blob/master/vyper/utils.py#L110), but it's important in the docs to note that we require it ;)

If one tests it outside the testsuite the transactions will fail.

@mkeen
Copy link
Contributor Author

mkeen commented May 15, 2018

@jacqueswww Added some notes. Let me know if you had something else in mind. Happy to make any changes necessary :)

@jacqueswww jacqueswww merged commit f7f751f into vyperlang:master May 21, 2018
@mkeen mkeen deleted the 606_add_rlplist_docs branch May 21, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants