Make multipage flag specifically target release and/or nightly
#1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The job still fails to load the ED of the CSS 2.2 spec to extract the list of pages, even with optimized loading (added in last commit). Something's rotten in the State of Network. In practice, build does not *need* to load the ED of the CSS 2.2 spec. It just does it because the spec is identified as multipage due to the /TR version. To avoid unnecessary spec loads, this update converts the `multipage` flag from a boolean to a string with 3 possible values: "all", "release", "nightly". The extraction of the list of pages is now only done on the version targeted by the `multipage` property. The update also serializes the extraction of pages to avoid sending too many requests at once. There are only a handful of specs for which we need to look for pages, serialization should not make build much longer than it already is.
dontcallmedom
approved these changes
Jun 3, 2024
Yes, and the situation is worse in Webref, we just don't see it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job still fails to load the ED of the CSS 2.2 spec to extract the list of pages, even with optimized loading (added in last commit). Something's rotten in the State of Network.
In practice, build does not need to load the ED of the CSS 2.2 spec. It just does it because the spec is identified as multipage due to the /TR version. To avoid unnecessary spec loads, this update converts the
multipageflag from a boolean to a string with 3 possible values: "all", "release", "nightly". The extraction of the list of pages is now only done on the version targeted by themultipageproperty.The update also serializes the extraction of pages to avoid sending too many requests at once. There are only a handful of specs for which we need to look for pages, serialization should not make build much longer than it already is.