-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing APA feedback in FXL Accessibility Document #2659
base: main
Are you sure you want to change the base?
Conversation
To me, the document still mix too many different problems for different audiences:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the title, the feedback from APA was to consider best practices and challenges because the document also does a good work of highlighting challenges for which we do not have a solution yet.
The recommendation was something like
EPUB fixed layout accessibility: best practices and challenges
George recommended to swap the last two words
EPUB fixed layout accessibility: challenges and best practices.
The title can be refined, but the main message for title was to mention both best practices and challenges.
Co-authored-by: Matt Garrish <[email protected]>
What about matching the naming along the lines of our other accessibility documents and make it something like:
|
I like this approach. |
This will make the document look like EPUB Accessibility 1.1. This is exactly what we want to avoid. This document is more about best practices and challenges for fixed layout. |
It puts it under the accessibility umbrella, but I don't think anyone would get too confused by a document called challenges and best practices. The alternative would be to put these under the FXL umbrella, so have: EPUB 3 Fixed Layouts -- Accessibility Challenges and Best Practices I think the more problematic name is going to be the techniques document. If this is best practices, how do you differentiate that document without it sounding like a proper accessibility guide. But that's a problem for another day, I suppose. |
This looks better:
“EPUB 3 Fixed Layouts -- Accessibility Challenges and Best Practices”
|
The key sentence of the document is in the overview:
It may be more apparent to have this stated at the very beginning of the abstract section. |
The link to see the diff doesn't work... |
Ya, we ran into this yesterday with the schema.org vocabulary. The spec-generator tool keeps timing out so the diff tool can't get the file to compare against. pr-preview isn't working for the same reason. @deniak do you know if this is a temporary glitch or something that needs fixing? |
It seems a recent upgrade of chromium broke spec-generator. I'll see how to fix this. |
@mattgarrish spec-generator should be back now. |
Yes, the diffs are working again. Thanks! |
This PR includes some edits to address the feedback we received regarding the FXL Accessibility document from APA during our session with them at TPAC.
Two main changes:
Feedback welcome!