Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test with empty frame and empty context. #158

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

davidlehn
Copy link
Contributor

Test matching an empty frame with data with a type with an empty context and other protected terms. This catches a specific Python implementation issue related to falsey empty dictionaries.

The test was reduced from an implementation bug report. It may be possible to reduce further, but this is fairly minimal.

Suggestions welcome for improved name/purpose text.

Test matching an empty frame with data with a type with an empty context
and other protected terms. This catches a specific Python implementation
issue related to falsey empty dictionaries.
@gkellogg gkellogg requested a review from pchampin February 7, 2024 21:11
@gkellogg
Copy link
Member

gkellogg commented Mar 6, 2024

This PR was discussed in a meeting.

#158 -> Pull Request 158 Add test with empty frame and empty context. (by davidlehn) [test:missing-coverage]
Niklas Lindström: For the record, PR 593 looks good.

@gkellogg gkellogg merged commit ded20d1 into main Mar 6, 2024
3 checks passed
@gkellogg gkellogg deleted the add-empty-frame-and-context-test branch March 6, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants