Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errata and boilerplate with reverted submodule #10

Merged
merged 20 commits into from
Feb 1, 2023
Merged

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Jan 31, 2023

This is the same as #7, but reverts adding the submodule using saved copies from https://github.com/w3c/rdf-common. In the GH Action, the submodule is added and the contents compared, which will fail if the local copy is not the same as that in the rdf-common repo.

GitHack-based preview.


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Feb 1, 2023, 10:11 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL


😭  Sorry, there was an error generating the HTML. Please report this issue!
Specification: http://labs.w3.org/spec-generator/uploads/k0AlWq/spec/index.html?isPreview=true%3FisPreview%3Dtrue&publishDate=2023-02-01
ReSpec version: 32.7.0
File a bug: https://github.com/w3c/respec/
Error: Error: Evaluation failed: Timeout: document.respec.ready didn't resolve in 28238ms.
    at ExecutionContext._ExecutionContext_evaluate (/u/spec-generator/node_modules/puppeteer-core/lib/cjs/puppeteer/common/ExecutionContext.js:229:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async ExecutionContext.evaluate (/u/spec-generator/node_modules/puppeteer-core/lib/cjs/puppeteer/common/ExecutionContext.js:107:16)
    at async generateHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:221:12)
    at async toHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:92:18)
    at async Object.generate [as respec] (file:///u/spec-generator/generators/respec.js:15:44)
    at async file:///u/spec-generator/server.js:252:48

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@gkellogg gkellogg requested review from afs and pchampin January 31, 2023 00:59
@gkellogg
Copy link
Member Author

gkellogg commented Jan 31, 2023

(Of course, this fails due to the unavailability of respec.org, which is used in the ReSpec API).

@gkellogg
Copy link
Member Author

@afs @pchampin please consider changes to auto-publish.yml for alternative to using submodule. Still uses it for comparison in GH Action.

@gkellogg
Copy link
Member Author

W3C Infrastructure having some problems, so Spec Generator is down right now, preventing investigation of what led to the PR Preview failure.

@gkellogg gkellogg mentioned this pull request Jan 31, 2023
@gkellogg gkellogg requested a review from TallTed February 1, 2023 16:51
@gkellogg
Copy link
Member Author

gkellogg commented Feb 1, 2023

@pchampin @TallTed I'd like to merge this and defer the issues raised in #7 (comment). @TallTed perhaps you can create an issue that captures your concerns and we can tag in the text for future consideration, but it is a meta-issue, as it affects numerous other specs.

Note that the changes for dealing with spec/common will need to be replicated in other specs, which is a bit painful, but needs to be done.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@gkellogg gkellogg merged commit 6539b58 into main Feb 1, 2023
@gkellogg gkellogg deleted the revert-submodule branch February 1, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants