Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update report on Enum values that ignore naming conventions in Web Authentication: An API for accessing Public Key Credentials - Level 3 #796

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

dontcallmedom-bot
Copy link
Contributor

This pull request was automatically created by Strudy upon detecting errors in Enum values that ignore naming conventions in Web Authentication: An API for accessing Public Key Credentials - Level 3.

Similar errors had already been detected. Please check that the diff is correct, and that the errors have not already been reported in https://github.com/w3c/webauthn.

If everything is OK, you can merge this pull request which will report the issue below to the repo, and update the underlying report file with a link to the said issue.


Title: >-
Enum values that ignore naming conventions in Web Authentication: An API for
accessing Public Key Credentials - Level 3
Tracked: >-
Willfull design
w3c/webauthn#2133 (comment)
Repo: 'https://github.com/w3c/webauthn'

While crawling Web Authentication: An API for accessing Public Key Credentials - Level 3, the following enum values were found to ignore naming conventions (lower case, hyphen separated words):

  • The value "conditionalCreate" of the enum ClientCapability does not match the expected conventions (lower case, hyphen separated words)
  • The value "conditionalGet" of the enum ClientCapability does not match the expected conventions (lower case, hyphen separated words)
  • The value "hybridTransport" of the enum ClientCapability does not match the expected conventions (lower case, hyphen separated words)
  • The value "passkeyPlatformAuthenticator" of the enum ClientCapability does not match the expected conventions (lower case, hyphen separated words)
  • The value "userVerifyingPlatformAuthenticator" of the enum ClientCapability does not match the expected conventions (lower case, hyphen separated words)
  • The value "relatedOrigins" of the enum ClientCapability does not match the expected conventions (lower case, hyphen separated words)
  • The value "signalAllAcceptedCredentials" of the enum ClientCapability does not match the expected conventions (lower case, hyphen separated words)
  • The value "signalCurrentUserDetails" of the enum ClientCapability does not match the expected conventions (lower case, hyphen separated words)
  • The value "signalUnknownCredential" of the enum ClientCapability does not match the expected conventions (lower case, hyphen separated words)

See Use casing rules consistent with existing APIs in Web Platform Design Principles document for guidance.

This issue was detected and reported semi-automatically by Strudy based on data collected in webref.

…thentication: An API for accessing Public Key Credentials - Level 3
@dontcallmedom dontcallmedom merged commit e5d90f8 into main Oct 2, 2024
1 check passed
@dontcallmedom dontcallmedom deleted the webauthn-3-wrongcaseenumvalue branch October 2, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants