Relax "queue a task" regexp for custom tasks #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular expression used to detect "queue a [custom] task" only accounted for cases where "[custom]" contained at most 2 words. This update relaxes the regular expression to account for situations where it contains 3 words, as happens in the Handwriting Recognition API. The regular expression remains somewhat strict on purpose not to match on too many things for now. We may need to relax it later on, I just propose to adjust it as we learn from experience.
3 tasks
dontcallmedom
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expression used to detect "queue a [custom] task" only accounted for cases where "[custom]" contained at most 2 words. This update relaxes the regular expression to account for situations where it contains 3 words, as happens in the Handwriting Recognition API.
The regular expression remains somewhat strict on purpose not to match on too many things for now. We may need to relax it later on, I just propose to adjust it as we learn from experience.