-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed path grammar #346
Fixed path grammar #346
Conversation
… grammar that's been extended to include Catmull-Rom.
The Working Group just discussed The full IRC log of that discussion<BogdanBrinza> topic: Fixed path grammar<BogdanBrinza> GitHub: https://github.com//pull/346 <BogdanBrinza> AmeliaBR: Can assign to me as a reviewer, but might not have enough time to work on this soon. If anybody else has time to review - feel free to balance this off Amelia, thank you! |
@fuchsia As indicated in the "Details" link for the "ipr" check on the PR, we've finally got a more formal process for external contributors to agree to the W3C information property commitments. Are you able to set up a W3C account and link it to GitHub, as the first step for getting you approved as a contributor? |
Thanks for the updates @fuchsia! I'll try to review soon. (Though if any of my SVG WG colleagues are able to do the review, that would be great, too.) |
This came up in last week's call. We will land the grammar updates as a sequence of smaller patches as they are easier to review. I propose landing #398 first. |
I believe that we fixed all issues we had with the path syntax. Please open a new issue and submit a new PR if this is not the case. |
As chronicled in #335, this extends the path grammar to allow decimals and exponents on numbers, as well as correcting all the defects described in this comment.
The EBNF used is that laid out for XML. It has been tested with a homebrew script that validates strings against EBNF.