Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align path number parsing with CSS Numbers. Fixes #331 #697

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Conversation

dirkschulze
Copy link
Contributor

No description provided.

@AmeliaBR
Copy link
Contributor

This looks like the fix to #335, not #331. Otherwise, looks good to me, but I'm not sure how to amend the PR so the correct issue gets fixed when it is merged.

@dirkschulze
Copy link
Contributor Author

@AmeliaBR It is both actually. #331 is related to paths as well. (All other occurrences reference CSS Number already.)

@AmeliaBR
Copy link
Contributor

Ok. Our resolution from last June was:

Use CSS numbers, allow UAs to implement SVG 1.1 numbers but strongly discourage to use them

So I guess this takes care of the first half of that, by making parsing match CSS. Do you want to add a paragraph regarding the second part? Possible wording:

The SVG 1 path grammar was defined in a way that allowed a trailing decimal point without any decimal digits (like 23. ). SVG 2 harmonizes number parsing with CSS, and makes this invalid. However, user agents may continue to accept numbers with trailing decimal points when parsing is unambiguous. Authors and authoring tools must not use this number format.

@dirkschulze
Copy link
Contributor Author

@AmeliaBR Updated PR

Copy link
Contributor

@AmeliaBR AmeliaBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification & the reference entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants