Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the error terms to the vocabulary #141

Merged
merged 3 commits into from
Aug 6, 2023
Merged

Conversation

iherman
Copy link
Member

@iherman iherman commented Jul 31, 2023

This PR is not against the main branch but, rather, against the branch behind #140

The PR extends the official security vocabulary to include all the error terms, as RDF individuals, in the security vocabulary.

Note that I have not defined the terms described in that version ("code", "title", etc.) that are in the proposed specification. It would require to add them as bona fide properties with the Errors class as a domain, but I do not believe those (JSON) objects will ever appear as Linked Data. If I am wrong, then these terms should be added to the vocabulary as well (although in that case, it is a possible problem to see that the terms like 'title' or 'code' are extremely generic, hopefully it will not lead to clashes...)

Base automatically changed from msporny-add-error-table to main August 5, 2023 21:43
@iherman
Copy link
Member Author

iherman commented Aug 6, 2023

@msporny I have the impression that the change conflicts are related to some other problems. This PR, originally, was meant to be merged into another branch (merged since) and the rebase to main changed things.

Because the merge conflicts are in the index.html file, ie, the core spec, I would prefer you take care of those. Thx.

@msporny
Copy link
Member

msporny commented Aug 6, 2023

@msporny I have the impression that the change conflicts are related to some other problems. This PR, originally, was meant to be merged into another branch (merged since) and the rebase to main changed things.

The branch it was intended to be merged into (the one that added the error table) was merged into main, at which point, Github automatically changes the old target branch (the one that added the error table) into the branch that the old target branch got merged into (main).

Because the merge conflicts are in the index.html file, ie, the core spec, I would prefer you take care of those. Thx.

I'll take care of it. :)

@msporny msporny force-pushed the iherma-add-error-table-vocab branch from a6fed15 to c4e9ec8 Compare August 6, 2023 16:21
@msporny
Copy link
Member

msporny commented Aug 6, 2023

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny force-pushed the iherma-add-error-table-vocab branch from 86ec721 to 6e4e86a Compare August 6, 2023 16:30
@msporny msporny merged commit 0d8cd2d into main Aug 6, 2023
1 check passed
@msporny msporny deleted the iherma-add-error-table-vocab branch August 6, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants