Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about typical autocomplete combos for conditional UI #1992

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Add note about typical autocomplete combos for conditional UI #1992

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ea6e598
Add note about typical autocomplete combos
MasterKale Nov 1, 2023
f120690
Try to generate valid HTML
MasterKale Nov 1, 2023
5c7ca4d
Incorporate PR feedback
MasterKale Nov 15, 2023
228a1f8
Enable linking to non-autofill credential type
MasterKale Nov 15, 2023
139405f
Explicitly mention that these are examples
MasterKale Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2408,10 +2408,20 @@ When this method is invoked, the user agent MUST execute the following algorithm
<dt id="GetAssn-ConditionalMediation-Interact-FormControl">
If <code>|options|.{{CredentialRequestOptions/mediation}}</code> is {{CredentialMediationRequirement/conditional}}
and the user interacts with an <{input}> or <{textarea}> form control with an <{input/autocomplete}> attribute whose value
contains a `"webauthn"` [=autofill detail token=],
contains `"webauthn"` as the last [=autofill detail token=],
MasterKale marked this conversation as resolved.
Show resolved Hide resolved
</dt>
:: <div class="note">
Note: The following are example values for the <{input/autocomplete}> attribute with the `"webauthn"`
[=autofill detail token=] in the correct position:

:: 1. If |silentlyDiscoveredCredentials| is not [=list/empty=]:
- `"username webauthn"`
- `"current-password webauthn"`
Comment on lines +2418 to +2419
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add autofill= to make the examples that tiny bit clearer, but this is fine as is too.

Suggested change
- `"username webauthn"`
- `"current-password webauthn"`
- `autofill="username webauthn"`
- `autofill="current-password webauthn"`


These examples are likely to trigger conditional UI across the greatest number of user agents. The expected ordering
of these tokens can be confirmed in the [=autofill detail token=] section of the the WHATWG HTML standard.
</div>

1. If |silentlyDiscoveredCredentials| is not [=list/empty=]:

1. Prompt the user to optionally select a [=DiscoverableCredentialMetadata=] (|credentialMetadata|) from |silentlyDiscoveredCredentials|.

Expand Down