Align RP ID string types #2074
Closed
Align RP ID string types #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rp.id` in `PublicKeyCredentialCreationOptions` and `rpId` in `PublicKeyCredentialRequestOptions` represent the same thing, but with different types. The WG agreed on the 2024-05-15 call that both should be `USVString`. Strictly speaking this is a breaking change (changing a type bound in input (contravariant) position to be more restrictive), but in practice this shouldn't be able to break any applications since then those credentials wouldn't have worked in `get()` anyway.
MasterKale
approved these changes
Jun 12, 2024
agl
approved these changes
Jul 10, 2024
|
From the WG @ 7/10: I don't have an objection to making this change, but it will mean that |
|
Alternative strategy: define a |
|
2024-07-10 WG call: We'll revert the change to |
…edentialRpEntityJSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rp.idinPublicKeyCredentialCreationOptionsandrpIdinPublicKeyCredentialRequestOptionsrepresent the same thing, but with different types. The WG agreed on the 2024-05-15 call that both should beUSVString. Strictly speaking this is a breaking change (changing a type bound in input (contravariant) position to be more restrictive), but in practice this shouldn't be able to break any applications since then those credentials wouldn't have worked inget()anyway.Fixes #2066.
Preview | Diff