Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NOTEs non-normative #2196

Merged
merged 34 commits into from
Jan 8, 2025
Merged

Make NOTEs non-normative #2196

merged 34 commits into from
Jan 8, 2025

Conversation

emlun
Copy link
Member

@emlun emlun commented Nov 13, 2024

Closes #1979.

This changes some NOTEs into normative text, and "promotes" some occurrences of "must" and "should" to their RFC 8174-enforced uppercase forms; thus formally speaking this introduces new normative language to the spec. But I have done my best to preserve what I interpret as the spirit of the existing language, so I think one can argue that these still count as "just" editorial changes.


Preview | Diff

emlun added 22 commits November 13, 2024 18:23
Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emlun
Copy link
Member Author

emlun commented Dec 2, 2024

@nadalin Did you have review comments on this?

@nadalin
Copy link
Contributor

nadalin commented Jan 6, 2025

@emlun Please Merge

@selfissued selfissued merged commit 15cebd7 into main Jan 8, 2025
2 checks passed
github-actions bot added a commit that referenced this pull request Jan 8, 2025
SHA: 15cebd7
Reason: push, by selfissued

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@emlun emlun deleted the issue-1979-notes branch January 13, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are notes in webauthn normative or informative?
7 participants