Proposed changes from review of PR 2224 #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
added
type:editorial
process:meta-pr
simoneonofri
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a meta-PR that would merge into #2224, not into main)
The first commit of these applies changes proposed in my review: #2224 (review)
In addition, I propose a few tweaks to improve style in my subjective opinion (3feccb4) - mainly spelling out a few things a little more explicitly and adding a few more links. I also reckon it might make sense to sort the changes in order of occurrence in the spec (ecd7e7c) - this makes the ordering feel less random and also roughly groups related topics closer together.
Preview | Diff