Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RTP timestamp members to Metadata objects #204

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

tonyherre
Copy link
Contributor

@tonyherre tonyherre commented Sep 6, 2023

Fixes #203


Preview | Diff

@tonyherre
Copy link
Contributor Author

@alvestrand @fippo explicitly

Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. Want to have another pair of eyes on it before Thursday next week - @youennf ?

Copy link
Collaborator

@youennf youennf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I wonder what the transition plan is for shipping implementations.
Maybe the use is low enough that there is no need to keep both for some amount of time?

@tonyherre
Copy link
Contributor Author

Thanks all!

I wonder what the transition plan is for shipping implementations. Maybe the use is low enough that there is no need to keep both for some amount of time?

My intention for chromium is to have both for some time. We don't have use counters yet though, so I'm not sure how long that would have to be.

@fippo
Copy link
Collaborator

fippo commented Sep 22, 2023

Sseveral CPaaS vendors have announced support for client side encryption which means an update cycle of at least six months I'd say.

@alvestrand
Copy link
Contributor

Editors meeting: Needs rebase, can be merged when rebased.

@tonyherre
Copy link
Contributor Author

Rebased, thanks.

@alvestrand alvestrand merged commit e258de1 into w3c:main Oct 4, 2023
1 check passed
github-actions bot added a commit that referenced this pull request Oct 4, 2023
SHA: e258de1
Reason: push, by alvestrand

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@fippo
Copy link
Collaborator

fippo commented Oct 5, 2023

I get validation failures in #140 due to the leftover RTCEncodedVideoFrame/timestamp et al which were removed here but that wasn't picked up by the validator so passed?

@saschanaz
Copy link
Member

Just saw this while maintaining https://github.com/microsoft/TypeScript-DOM-lib-generator/, is it safe to remove this without webcompat issue while it's shipped on every engine per MDN?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move RTP Timestamp to Metadata and rename
5 participants