-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an API for a "keyframe has been requested" event #215
Conversation
Fixes #210 |
index.bs
Outdated
|
||
## Events ## {#RTCRtpScriptTransformer-events} | ||
|
||
The following events fire on an {{RTCRtpScriptTransformer}}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should rewrite as "when the UA decides that a key frame has been requested, the UA will queue a task to fire an event...."
LGTM if @youennf agrees. |
Waiting for @youennf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's first introduce onkeyframerequest without introducing the mixins, we can do that as a follow-up.
Mixins removed as agreed during the editors meeting. |
Despite bikeshed refs --for=Event --text='canceled flag' returning a value (spec=dom), I'm unable to make {{Event/canceled flag}} autolink. @dontcallmedom help? |
the correct syntax would be |
Co-authored-by: Dominique Hazael-Massieux <[email protected]>
Thanks - that worked. I could have sworn that I tried that before! |
SHA: 678a265 Reason: push, by alvestrand Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This issue was discussed in WebRTC December 12 2023 meeting – 12 December 2023 (Keyframe API) |
This is split from #207 - in the October interim discussion, the overall congestion control API was seen as requiring more discussion, but the keyframe proposal was thought reasonable to pursue on its own.
I preserved the split into "ScriptSource" and "ScriptSink" interfaces - I think that can be valuable for documenting which interfaces are facing in which direction on the transformer.
Comments welcome.
Preview | Diff