-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add captureTimestamp and senderCaptureTimeOffset to frame metadata #228
base: main
Are you sure you want to change the base?
Conversation
@aboba Can we add this to the next interim's agenda please? |
@Orphis Yes. |
This issue was mentioned in WEBRTCWG-2024-05-21 (Page 22) |
71a2372
to
740b9cf
Compare
740b9cf
to
1613039
Compare
1613039
to
1a211a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR overall LGTM modulo a normative reference issue.
@@ -48,6 +48,11 @@ spec:webidl; type:dfn; text:resolve | |||
"CloneArrayBuffer": { | |||
"href": "https://tc39.es/ecma262/#sec-clonearraybuffer", | |||
"title": "CloneArrayBuffer" | |||
}, | |||
"RTP-EXT-CAPTURE-TIME": { | |||
"href": "http://www.webrtc.org/experiments/rtp-hdrext/abs-capture-time", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This normative reference redirects to a googlesource link. I'll need to check with folks internally how to handle this.
Can we add a note mentioning any efforts to standardize this?
My understanding is after an IETF effort it would end up here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See w3c/webrtc-extensions#216. I worry if we merge this it creates a blocker for advancement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have Harold’s draft (which will be up for adoption in IETF AVTCORE WG): https://datatracker.ietf.org/doc/draft-alvestrand-avtcore-abs-capture-time/
@@ -358,6 +381,8 @@ dictionary RTCEncodedVideoFrameMetadata { | |||
sequence<unsigned long> contributingSources; | |||
long long timestamp; // microseconds | |||
unsigned long rtpTimestamp; | |||
DOMHighResTimeStamp captureTimestamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to captureTime for consistency with rVFC and others.
@@ -48,6 +48,11 @@ spec:webidl; type:dfn; text:resolve | |||
"CloneArrayBuffer": { | |||
"href": "https://tc39.es/ecma262/#sec-clonearraybuffer", | |||
"title": "CloneArrayBuffer" | |||
}, | |||
"RTP-EXT-CAPTURE-TIME": { | |||
"href": "http://www.webrtc.org/experiments/rtp-hdrext/abs-capture-time", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"href": "http://www.webrtc.org/experiments/rtp-hdrext/abs-capture-time", | |
"href": "https://www.webrtc.org/experiments/rtp-hdrext/abs-capture-time", |
Editors can integrate pending the adoption of https://datatracker.ietf.org/doc/draft-alvestrand-avtcore-abs-capture-time/ |
Fixes #225
Preview | Diff