Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create inkscope-fuzzer-1.md #1163

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Create inkscope-fuzzer-1.md #1163

merged 2 commits into from
Apr 9, 2024

Conversation

feliam
Copy link
Contributor

@feliam feliam commented Mar 28, 2024

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2155

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the delivery, @feliam. I am going through the instructions in the readme, and I keep running into this error below. Any idea what I might be missing?

> cargo test                        
   Compiling drink v0.10.0 (https://github.com/inkscopexyz/inkscope-drink.git?rev=b25b886#b25b8868)
error[E0283]: type annotations needed
   --> /home/anon/.cargo/git/checkouts/inkscope-drink-8150a806fd73cad9/b25b886/drink/src/session/record.rs:195:26
    |
195 |                         .decode_contract_event(&signature_topic.into(), &mut &*data.encode())
    |                          ^^^^^^^^^^^^^^^^^^^^^ ----------------------- type must be known at this point
    |                          |
    |                          cannot infer type of the type parameter `Hash` declared on the method `decode_contract_event`
    |
    = note: cannot satisfy `_: AsRef<[u8]>`
note: required by a bound in `ContractMessageTranscoder::decode_contract_event`
   --> /home/anon/.cargo/registry/src/index.crates.io-6f17d22bba15001f/contract-transcode-4.0.2/src/lib.rs:300:15
    |
294 |     pub fn decode_contract_event<Hash>(
    |            --------------------- required by a bound in this associated function
...
300 |         Hash: AsRef<[u8]>,
    |               ^^^^^^^^^^^ required by this bound in `ContractMessageTranscoder::decode_contract_event`
help: consider specifying the generic argument
    |
195 |                         .decode_contract_event::<Hash>(&signature_topic.into(), &mut &*data.encode())
    |                                               ++++++++

For more information about this error, try `rustc --explain E0283`.
error: could not compile `drink` (lib) due to 1 previous error
 ~/inkscope/inkscope-fuzzer | on develop !1 ...................................................... at 22:04:51 
> cargo -V
cargo 1.76.0 (c84b36747 2024-01-18)
 ~/inkscope/inkscope-fuzzer | on develop !1 ...................................................... at 22:05:02 
> cargo contract -V
cargo-contract-contract 3.2.0-unknown-x86_64-unknown-linux-gnu

@semuelle semuelle self-assigned this Apr 8, 2024
@0xLucca
Copy link
Contributor

0xLucca commented Apr 8, 2024

Hi @semuelle,

The issue with th build is likely due to a problem with how Rust is resolving the contract-transcode crate included in the drink crate. Please try building with the locked flag:

cargo build --release --locked

Also, please make sure you are working on the milestone-1 branch, as the develop branch is currently under active development and may not be in a stable state.

Let us know if this resolves the problem or if you have any other questions

@feliam feliam requested a review from semuelle April 8, 2024 21:08
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification, @feliam. I hadn't noticed the milestone-1 branch. Everything is compiling and running now, thanks. Your milestone is hereby accepted. You can find my evaluation notes here.

@semuelle semuelle merged commit 3784efb into w3f:master Apr 9, 2024
3 checks passed
Copy link

github-actions bot commented Apr 9, 2024

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Copy link

github-actions bot commented Apr 9, 2024

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

@RouvenP
Copy link

RouvenP commented Apr 15, 2024

hi @feliam we sent the payment last Friday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants