Amendment: Infimum M2 dependencies #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
admin-review
keeganquigley
added
ready for review
keeganquigley
approved these changes
Dec 11, 2024
semuelle
approved these changes
Dec 11, 2024
PieWol
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amendment
This PR proposes an amendment to the stated dependencies used in the Infimum grant application. Specifically, arkworks-rs/groth16 (licensed under MIT) has been used instead of zkcrypto/bellman. This decision was made primarily due to the improved ergonomics offered by arkworks, along with its stronger community support and ongoing maintenance.
This amendment is made in cross-reference to the milestone 2 delivery PR: w3f/Grant-Milestone-Delivery#1231