Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller keys deprecation #700

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Controller keys deprecation #700

merged 4 commits into from
Sep 8, 2023

Conversation

heversonbr
Copy link
Contributor

Tagged definition as deprecated and removed controller keys information from other parts of the text due to deprecation

Handles issue: #692

bhargavbh
bhargavbh requested changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@bhargavbh bhargavbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe link to the wiki explaining the stashing keys can be added at the appropriate place?

Noc2
Noc2 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed: "The Stash key holds the majority of the users’ funds and should neither be shared with anyone, saved on an online device, nor used to submit extrinsics." (doesn't need to be part of the spec). Otherwise, feel free to merge

@heversonbr heversonbr merged commit a04bc7f into main Sep 8, 2023
3 checks passed
@heversonbr heversonbr deleted the hbr/controller_account_deprecation branch September 8, 2023 11:46
@heversonbr heversonbr mentioned this pull request Sep 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhargavbh bhargavbh bhargavbh approved these changes

@Noc2 Noc2 Noc2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heversonbr @Noc2 @bhargavbh