Fiono11's OLAF #110
Open
Fiono11's OLAF #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvements Add tests Fix tests Return keys from simplpedpop_recipient_all instead of points and scalars Replace pub(crate) with pub(super) Fix in ciphertexts loop Add wrapper types Implement SecretShare and EncryptedSecretShare types Implement SecretPolynomial and PolynomialCommitment types Restructuring of files Remove derive_key_from_scalar Remove ephemeral key Add Identifier type Add identifiers to dkg_output Remove proof of possession signature Improvements Fix deserialization of dkg output Remove unwrap Improve errors Add polynomial tests Reimplement ephemeral key and proof of possession Merge changes from final_frost branch to simplpedpop Undo formatting
Appears this works everywhere
We could expose this behind some HAZMAT feature I guess, not sure.
This was referenced Jul 30, 2024
Closed
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor cleanup, primarily removing the dangeorus "flexible round optimized" aka 1-round part that seperates FROSTs from other 2-round non-deterministic multi-signatures.