This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
tests/gl_basic: Fix compilation for surfaceless_egl #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the only platform selected is surfaceless_egl test_gl_basic_glesX_fwdcompat
is not defined which make compiler unhappy:
--------------------------------------->8-------------------------------------
.../tests/functional/gl_basic_test.c:581:24: error: 'test_gl_basic_gles2_fwdcompat' undeclared (first use in this function); did you mean 'test_gl_basic_gles1_fwdcompat'?
unit_test_make(test_gl_basic_gles2_fwdcompat), \
^
--------------------------------------->8-------------------------------------
Not really sure to which extent fwdcompact is supported in
surfaceless_egl but an educated guess is it's pretty much the same as
for GBM.
Also while at it fixing wrong comment.
Signed-off-by: Alexey Brodkin <[email protected]>
Cc: Gurchetan Singh <[email protected]>
Cc: Emil Velikov <[email protected]>
Cc: Chad Versace <[email protected]>
Cc: Erico Nunes <[email protected]>
Cc: Haixia Shi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the only platform selected is surfaceless_egl test_gl_basic_glesX_fwdcompat
is not defined which make compiler unhappy:
--------------------------------------->8-------------------------------------
.../tests/functional/gl_basic_test.c:581:24: error: 'test_gl_basic_gles2_fwdcompat' undeclared (first use in this function); did you mean 'test_gl_basic_gles1_fwdcompat'?
unit_test_make(test_gl_basic_gles2_fwdcompat),
^
--------------------------------------->8-------------------------------------
Not really sure to which extent fwdcompact is supported in
surfaceless_egl but an educated guess is it's pretty much the same as
for GBM.
Also while at it fixing wrong comment.
Signed-off-by: Alexey Brodkin [email protected]
Cc: Gurchetan Singh [email protected]
Cc: Emil Velikov [email protected]
Cc: Chad Versace [email protected]
Cc: Erico Nunes [email protected]
Cc: Haixia Shi [email protected]