Add cluster support via Resolver #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruslan Bayandinov <[email protected]>
|
This works well for me , would be great to see it merged |
|
I wish you would have attributed the change to me properly, but glad this made it in. |
Sorry? I just merged the PR because it looked good... your PR was closed. OP referenced (linked) your PR in his original comment not sure what else should have been done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for RabbitMQ clusters to connect up to one of a number of servers.
It does this through a Resolver interface which has a single method called Resolve() which can return a list of servers. There is a standard implementation included called StaticResolver that will just take a list of URLS to connect to and optionally shuffle that list.
This interface approach allows for implementers of the library to extend for service discovery or other advanced typologies.
Fixes: #148
Revived this PR #156