Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more defensive with fetching schema version from Django migration records #712

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Sep 6, 2023

Fixes #706

@zerolab
Copy link
Collaborator Author

zerolab commented Sep 6, 2023

Here's the packaged version for this PR
wagtail_localize-1.5.2a1.tar.gz

@urlsangel any chance you could give it a spin?

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (3f060bd) 93.23% compared to head (3552b7d) 93.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   93.23%   93.27%   +0.03%     
==========================================
  Files          47       47              
  Lines        3905     3908       +3     
  Branches      579      579              
==========================================
+ Hits         3641     3645       +4     
  Misses        154      154              
+ Partials      110      109       -1     
Files Changed Coverage Δ
wagtail_localize/models.py 96.23% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@urlsangel
Copy link

Here's the packaged version for this PR wagtail_localize-1.5.2a1.tar.gz

@urlsangel any chance you could give it a spin?

@zerolab Sure thing, I'll attempt to do so in the next hour or so 👍

Copy link

@urlsangel urlsangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zerolab

Tests pass for me locally when when using this version, great work 👍

@drcongo
Copy link

drcongo commented Sep 6, 2023

@zerolab I'm working on the same project as @urlsangel so consider it fixed for me too. Thank you!

@zerolab
Copy link
Collaborator Author

zerolab commented Sep 6, 2023

Great to hear. Will merge and get a release out tomorrow morning

@zerolab zerolab merged commit d40ad87 into main Sep 7, 2023
10 of 14 checks passed
@zerolab zerolab deleted the chore/get-schema-version-wrapped branch September 7, 2023 08:33
@zerolab
Copy link
Collaborator Author

zerolab commented Sep 7, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail when using pytest with SQLite and TranslationSource.get_or_create_from_instance
4 participants