Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filtering the translation report by status #830

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexkiro
Copy link

@alexkiro alexkiro commented Oct 9, 2024

Adds a new filter for filtering by the status of the translation in the translation report.

Note that the filter will not be consistent with the column for translations with sources that don't have any strings, until #829 is merged. So it will appear to not function correctly for such cases.

- Annotate the report query with a flag for the status
- Add a status filter in the report page
- Add tests for the new functionality
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.07%. Comparing base (caf14b8) to head (c7a4241).

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #830    +/-   ##
========================================
  Coverage   93.07%   93.07%            
========================================
  Files          47       47            
  Lines        4144     4146     +2     
  Branches      704      529   -175     
========================================
+ Hits         3857     3859     +2     
  Misses        173      173            
  Partials      114      114            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants