Resolve api_key_vault_cmd like wakatime-cli does #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix #374.
|
It looks good to me, wdyt @alanhamlett? |
alanhamlett
reviewed
Apr 10, 2024
alanhamlett
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package was treating the entire config value of
api_key_vault_cmdas one executable name, rather than treating it as a shell command --- but it also probably shouldn't treat it as a shell command, as wakatime-cli doesn't do that either.wakatime-cli instead treats the value as a space-separated list of the executable and its arguments:
https://github.com/wakatime/wakatime-cli/blob/1fd560a/cmd/params/params.go#L707-L719
This PR makes vscode-wakatime mimick that behavior.
This should fix #387.