Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/prefilter for typescript #38

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix/prefilter for typescript #38

merged 1 commit into from
Aug 26, 2024

Conversation

righ
Copy link
Member

@righ righ commented Aug 26, 2024

Addressed the issue of prefilter evaluating elements without satisfying them, causing results to be overfiltered.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 92.43243% with 14 lines in your changes missing coverage. Please review.

Project coverage is 86.04%. Comparing base (84f670d) to head (014aa00).
Report is 2 commits behind head on master.

Files Patch % Lines
typescript/src/controller.ts 95.10% 6 Missing and 1 partial ⚠️
typescript/src/index.ts 66.66% 3 Missing and 3 partials ⚠️
typescript/src/criteria/greedy.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   85.81%   86.04%   +0.22%     
==========================================
  Files          17       18       +1     
  Lines         691      745      +54     
  Branches      112      117       +5     
==========================================
+ Hits          593      641      +48     
- Misses         63       70       +7     
+ Partials       35       34       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@righ righ changed the title Fix/prefilter Fix/prefilter for typescript Aug 26, 2024
@righ righ marked this pull request as ready for review August 26, 2024 17:38
@righ righ merged commit b104389 into master Aug 26, 2024
5 checks passed
@righ righ deleted the fix/prefilter branch August 26, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants