Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak: english text improvements #422

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

gabeklavans
Copy link
Contributor

No description provided.

Copy link
Member

@bourvill bourvill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your first contribution and this PR. Some elements seem open to discussion; perhaps we could find better terms to explain it more clearly.

Section("Badge") {
Toggle("Show badge", isOn: $badge)
Section("Notifications") {
Toggle("Show unread articles badge", isOn: $badge)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not related to the unread articles, but rather related to the total articles of the user’s default setting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my mistake. I thought I tested that but maybe I got confused about the numbers I was seeing. I can re-word.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's the new wording?

.frame(idealWidth: .infinity, maxWidth: .infinity, alignment: .leading)
}
GroupBox("wallabag Plus is available on my instance ?") {
Text("No, wallabag plus is a premium feature only available on your iOS devices")
GroupBox("Is wallabag Plus available on my self-hosted instance?") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not only restricted to self-hosted instance. Ex wallabag.it is not self-hosted instance and is not concerned by this feature

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm not too attached to this change. I just wanted to make it clearer what "my instance" was referring to, but I can just get rid of this line change if it only adds a different type of confusion.

@gabeklavans gabeklavans force-pushed the tweak/text-improvements branch from 21a147e to e49cf22 Compare November 4, 2024 21:54
Copy link
Member

@bourvill bourvill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution!

@bourvill bourvill merged commit bbead69 into wallabag:main Nov 4, 2024
1 check failed
@bourvill bourvill modified the milestones: 7.3.0, 7.4.0 Nov 4, 2024
@bourvill
Copy link
Member

bourvill commented Nov 4, 2024

A new version including your contribution has been sent for validation by Apple. It will be available in version 7.4.0 once accepted by Apple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants