Fix destructuring #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix destructuring, add body parameter to errors, convert body to JSON
walmat
reviewed
Nov 28, 2019
| const { PortfolioItem: { chainId, skuUuid }} = body; | ||
|
|
||
| return { chainId, skuUuid }; | ||
| const body = JSON.parse(res.body); |
There was a problem hiding this comment.
Is the call to JSON.parse() needed? AFAIK rp takes care of the transformer for you depending on the content-type in the response (and a few other requirements).
| @@ -108,10 +109,10 @@ export default class Asks extends Base { | |||
|
|
|||
| checkStatus(res); | |||
|
|
|||
| const { body } = res; | |||
| const { PortfolioItem: { chainId, skuUuid }} = body; | |||
| const body = JSON.parse(res.body); | |||
| @@ -146,9 +147,9 @@ export default class Asks extends Base { | |||
|
|
|||
| checkStatus(res); | |||
|
|
|||
| const { body } = res; | |||
| const { PortfolioItem: { chainId, skuUuid } } = body; | |||
| const body = JSON.parse(res.body); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix destructuring, add body parameter to errors, convert body to JSON