add new endpoint to fetch transactions burning most steps by entrypoint selector #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added function to get top transactions and modified get_common_data to return top transactions * added new migration script * revert changes in 001_init.up.sql and added 005_add_get_top_transactions_by_steps.up.sql * fixed function to order by steps correctly
https://github.com/saimeunt/starkflare-indexer into feat/transactions-burning-most-steps-by-entrypoint-10
* add entrypoints burning most steps * Check if contractAddress is null * Top transactions by steps (walnuthq#2) * added function to get top transactions and modified get_common_data to return top transactions * added new migration script * revert changes in 001_init.up.sql and added 005_add_get_top_transactions_by_steps.up.sql * fixed function to order by steps correctly * feat: L1 gas stats for last 7 days (walnuthq#4) * add entrypoints burning most steps * rename migration file --------- Co-authored-by: Roman <[email protected]> Co-authored-by: ADR!AN <[email protected]> Co-authored-by: Jaipal Jadeja <[email protected]>
jaipaljadeja
suggested changes
Jun 4, 2024
There was a problem hiding this comment.
Thank you for your contribution! Everything looks good.
Just a small change, can you please remove 'param' word from these keys for the endpoint payload. this ensures uniformity in future as well as better DX.
Currently its taking args payload as:
{
"contract_address_param": "0x04505a9f06f2bd639b6601f37a4dc0908bb70e8e0e0c34b1220827d64f4fc066",
"entrypoint_selector_param": "0x033076126f032617037f0b2fe939518f69cc8b9e9689b6ab065bb612662c53fc"
}
make it:
{
"contract_address": "0x04505a9f06f2bd639b6601f37a4dc0908bb70e8e0e0c34b1220827d64f4fc066",
"entrypoint_selector": "0x033076126f032617037f0b2fe939518f69cc8b9e9689b6ab065bb612662c53fc"
}
Edit: not payload but url params
|
@jaipaljadeja You're right, I just made the changes and added a new migration to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new endpoint to fetch the transactions burning most steps by contract address and entrypoint selector.
Closes walnuthq/starkflare#10