Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix refresh token logic #54

Merged
merged 5 commits into from
Nov 7, 2023
Merged

fix refresh token logic #54

merged 5 commits into from
Nov 7, 2023

Conversation

walnuts1018
Copy link
Owner

@walnuts1018 walnuts1018 commented Nov 7, 2023 •
edited
Loading

why

  • 現状の実装だと同時にリクエストが飛んだ時対処できない
    • 後から送られたリクエストのrefresh_tokenは古いtokenであり、それで上書きされると更新が効かない

what

  • redisにcacheするようにして、tokenのrefresh_tokenと同じかどうか検証するように
  • 一応軽く暗号化もした

@walnuts1018 walnuts1018 changed the title Refactoring fix refresh token logic Nov 7, 2023
@walnuts1018 walnuts1018 enabled auto-merge November 7, 2023 14:17
@walnuts1018 walnuts1018 merged commit 5e0b642 into main Nov 7, 2023
4 checks passed
@walnuts1018 walnuts1018 deleted the refactoring branch November 7, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@walnuts1018