Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Max LB name length #166

Merged
merged 2 commits into from
Jan 16, 2024
Merged

fix: Max LB name length #166

merged 2 commits into from
Jan 16, 2024

Conversation

zacharyblasczyk
Copy link
Contributor

No description provided.

@zacharyblasczyk zacharyblasczyk requested a review from gls4 as a code owner January 16, 2024 19:22
@zacharyblasczyk zacharyblasczyk requested a review from a team January 16, 2024 19:22
main.tf Outdated Show resolved Hide resolved
gls4
gls4 previously requested changes Jan 16, 2024
Copy link
Contributor

@gls4 gls4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's simply set the name of the ALB to the namespace (or a substring thereof) and be done with it.

Co-authored-by: Justin Brooks <[email protected]>
@jsbroks
Copy link
Member

jsbroks commented Jan 16, 2024

@gls4 we cannot because that is already used by the other lb

@zacharyblasczyk zacharyblasczyk requested a review from gls4 January 16, 2024 19:46
@zacharyblasczyk zacharyblasczyk dismissed gls4’s stale review January 16, 2024 19:47

This is blocking a fix that needs to go out.

@zacharyblasczyk zacharyblasczyk merged commit 85bd266 into main Jan 16, 2024
5 checks passed
@zacharyblasczyk zacharyblasczyk deleted the zacharyb/alb-max-length branch January 16, 2024 19:47
jsbroks pushed a commit that referenced this pull request Jan 16, 2024
### [4.1.2](v4.1.1...v4.1.2) (2024-01-16)

### Bug Fixes

* Max LB name length ([#166](#166)) ([85bd266](85bd266))
@jsbroks
Copy link
Member

jsbroks commented Jan 16, 2024

This PR is included in version 4.1.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants