Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add internalJWTMap variables used for inter service request authentication #309

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Nov 21, 2024

Adds a new variable kubernetes_cluster_oidc_issuer_url variable, and a local variable defining the weave trace server service account name. These two values are used to set the internalJWTMap value in our helm charts which defines the mapping of subject to issuer, which is used to authenticate internal service communication

@KyleGoyette KyleGoyette changed the title Kyle/jwt settings feat: Add internalJWTMap variables used for inter service request authentication Nov 21, 2024
@KyleGoyette KyleGoyette marked this pull request as ready for review November 27, 2024 00:21
@raubitsj raubitsj self-requested a review November 27, 2024 17:52
Copy link
Member

@raubitsj raubitsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the README didnt get updated yet. make sure that action runs

@KyleGoyette KyleGoyette merged commit f281ca4 into main Dec 2, 2024
6 of 7 checks passed
@KyleGoyette KyleGoyette deleted the kyle/jwt-settings branch December 2, 2024 23:30
jsbroks pushed a commit that referenced this pull request Dec 2, 2024
## [5.2.0](v5.1.0...v5.2.0) (2024-12-02)

### Features

* Add internalJWTMap variables used for inter service request authentication ([#309](#309)) ([f281ca4](f281ca4))
@jsbroks
Copy link
Member

jsbroks commented Dec 2, 2024

This PR is included in version 5.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants