Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding bigtable and pubsub support for GCP #178

Open
wants to merge 63 commits into
base: main
Choose a base branch
from
Open

feat: Adding bigtable and pubsub support for GCP #178

wants to merge 63 commits into from

Conversation

danielpanzella
Copy link
Contributor

Replaces #176 and removes all of the hardcoded values

danielpanzella and others added 30 commits November 14, 2024 16:45
@danielpanzella
feat: Adding bigtable and pubsub support for GCP
cc4dbae
@github-actions
terraform-docs: automated action
f4c0b19
@danielpanzella
fix: Adding IAM members for bigtable and pubsub
6585977
@danielpanzella
fix: correct colliding names and pass service_account
8c028bb
@danielpanzella
fix: correct role name
e1bcac3
@danielpanzella
fix: more permissions for now
50095ff
@danielpanzella
fix: wire things through to the chart
79dff9d
@danielpanzella
chore: terraform fmt
454b376
@danielpanzella
chore: add the bigtable tables and updated the envvars
a73c3bc
@danielpanzella
fix: add ordering requirement for flat-run-fields-updater, rename top…
0a3d5a3 
…ic to match what is used in kafka
@danielpanzella
fix: add FRFU service and create seperate variables for enabling file…
9517a6b 
…stream and FRFU
@github-actions
terraform-docs: automated action
c59af74
@danielpanzella
feat: enable bigtablev3 and parameterize bigtable
73acfd4
@github-actions
terraform-docs: automated action
9da0fbb
@danielpanzella
chore: add minimal docs for enabling
1726848
@danielpanzella
chore: bump chart version
62f1f8c
@danielpanzella
chore: more README.md
54c82cc
@danielpanzella
chore: bump chart
f8064ad
@danielpanzella
Update README.md
88346ad 
Add examples for resources and correct the name of flat-run-fields-updater in configs
@venky-wandb
google provider version compatibility
c37913f
@danielpanzella
feat: CMEK permissions for bigtable and pubsub
1982a83
@danielpanzella
chore: terraform fmt
fcca13d
@danielpanzella
chore: allow pubsub user to access kms key
9aa0efa
@danielpanzella
fix: rename key association
4729852
@danielpanzella
fix: move the kms permissions around
25d0aed
@danielpanzella
fix: missed wiring the variable through
75cbf81
@danielpanzella
fix: remove tf version pin
2058ab3
@danielpanzella
fix: map the correct role when using workload identity
96938db
@danielpanzella
fix: remove user from kms key as that is not needed, and reformat var…
5c6ea5d 
…iables to work with or without workload identity
@danielpanzella
fix: missed these variable references
63554f9
@danielpanzella danielpanzella marked this pull request as ready for review November 25, 2024 21:33
@danielpanzella danielpanzella requested a review from a team as a code owner November 25, 2024 21:33
danielpanzella and others added 13 commits November 25, 2024 14:59
@danielpanzella
fix: add gc policies for bigtable
ad5d5b7
@danielpanzella
fix: use max_version directly instead of custom rules
73fb249
@danielpanzella
fix: correct format of max-version
78e3f90
@danielpanzella
fix: Bump operator chart version
9eaeeeb
@github-actions
terraform-docs: automated action
0f72400
@danielpanzella
feat: Remove unused public address, don't assign nodes public addresses
57c4d8b
@danielpanzella
Merge remote-tracking branch 'origin/main' into danielpanzella/bigtab…
a2ee686 
…le-and-pubsub-prep-for-merge
@danielpanzella
feat: Don't set max_allowed_packet via variable, we will set it via d…
e29b0f8 
…atabase_flags
@github-actions
terraform-docs: automated action
e01b85f
@danielpanzella
feat: revert private node ips
078b8cd
@danielpanzella
feat: Binlog_row_image needs to have lowercase value
bee1d98
@levinandrew
Merge branch 'main' into danielpanzella/bigtable-and-pubsub-prep-for-…
b61cacf 
…merge
@danielpanzella
Merge branch 'main' into danielpanzella/bigtable-and-pubsub-prep-for-…
9bc5d91 
…merge
@danielpanzella danielpanzella changed the title Adding bigtable and pubsub support for GCP feat: Adding bigtable and pubsub support for GCP Dec 2, 2024
danielpanzella and others added 10 commits December 2, 2024 13:29
@danielpanzella
fix: Remove unused variables
18ecb88
@github-actions
terraform-docs: automated action
c98c958
@danielpanzella
fix: terraform fmt
f203161
@danielpanzella
Merge branch 'main' into danielpanzella/bigtable-and-pubsub
95e8517
@danielpanzella
Merge branch 'main' into danielpanzella/bigtable-and-pubsub-prep-for-…
fb1f754 
…merge
@danielpanzella
Merge branch 'main' into danielpanzella/bigtable-and-pubsub-prep-for-…
c2b7924 
…merge
@danielpanzella
Merge branch 'main' into danielpanzella/bigtable-and-pubsub
114c6fe
@danielpanzella
fix: rename bigtable values to match helm chart and remove enabled fl…
e6097ca 
…ag as this should be done via channels and the format is changed
@danielpanzella
Merge branch 'danielpanzella/bigtable-and-pubsub' into danielpanzella…
da96094 
…/bigtable-and-pubsub-prep-for-merge
@danielpanzella
Merge branch 'main' into danielpanzella/bigtable-and-pubsub-prep-for-…
4572d03 
…merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielpanzella @venky-wandb @levinandrew