Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable bufstream to use workload identity for auth #188

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ locals {
create_network = var.network == null
k8s_sa_map = {
app = "wandb-app"
bufstream = "wandb-bufstream"
parquet = "wandb-parquet"
flat_runs = "wandb-flat-run-fields-updater"
weave = "wandb-weave"
Expand Down Expand Up @@ -321,11 +322,22 @@ module "wandb" {
internalJWTMap = [
{
subject = "system:serviceaccount:default:${local.k8s_sa_map.weave_trace}"
issuer = var.kubernetes_cluster_oidc_issuer_url
issuer = var.kubernetes_cluster_oidc_issuer_url
}
]
}

bufstream = {
bufstream = {
serviceAccount = var.create_workload_identity ? {
name = local.k8s_sa_map.bufstream
annotations = { "iam.gke.io/gcp-service-account" = module.service_accounts.sa_account_role }
} : {
name = ""
annotations = {}
}
}
}
ingress = {
create = var.public_access # external ingress for public connection
nameOverride = var.namespace
Expand Down
Loading